feat(kms-connector): user decryption request verification#2345
Draft
eudelins-zama wants to merge 7 commits intofeat/RFC-012-016from
Draft
feat(kms-connector): user decryption request verification#2345eudelins-zama wants to merge 7 commits intofeat/RFC-012-016from
eudelins-zama wants to merge 7 commits intofeat/RFC-012-016from
Conversation
maksymsur
reviewed
Apr 24, 2026
Comment on lines
+262
to
+263
| startTimestamp: U256::from(start_timestamp as u64), | ||
| durationSeconds: U256::from(duration_seconds as u64), |
Contributor
There was a problem hiding this comment.
The concern here is the unchecked as u64 cast. A negative or corrupt DB value would wrap silently into a large positive number. u64::try_from(...) would be safer.
maksymsur
reviewed
Apr 24, 2026
| for r in rows { | ||
| if e.payload.signature.to_vec() == r.try_get::<Vec<u8>, _>("signature")? | ||
| && e.payload.userAddress | ||
| == Address::from(r.try_get::<[u8; 20], _>("user_address")?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zama-ai/fhevm-internal/issues/1288